Skip to content

Rx dummy cycles #20309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rx dummy cycles #20309

wants to merge 1 commit into from

Conversation

@mif1-nordic
Copy link
Contributor

@mif1-nordic mif1-nordic commented Feb 12, 2025

Requires #20116

@mif1-nordic mif1-nordic requested review from a team as code owners February 12, 2025 08:59
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 12, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 21

Inputs:

Sources:

sdk-nrf: PR head: 910468112e4addaf25c2ef662bdb74ab80d7b8f4

more details

sdk-nrf:

PR head: 910468112e4addaf25c2ef662bdb74ab80d7b8f4
merge base: 9a87aabcdd4474eb112f5059c5f319b2c029265e
target head (main): a54e53583aeb5b4072d8bece01f324a446cc9d90
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt-nrf54l15.s
│  │  │  │  │  │ hrt.c
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: acee3b0b2b
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:acee3b0b2b_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 39
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 12, 2025

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@masz-nordic masz-nordic added this to the 3.0.0 milestone Feb 12, 2025
@mif1-nordic mif1-nordic force-pushed the rx_dummy_cycles branch 3 times, most recently from 9531e47 to 55efedc Compare February 12, 2025 10:19
magp-nordic
magp-nordic reviewed Feb 13, 2025
View reviewed changes
@mif1-nordic mif1-nordic force-pushed the rx_dummy_cycles branch 3 times, most recently from 441b15c to 1c3c3e3 Compare February 13, 2025 13:33
@nordicjm
Copy link
Contributor

nordicjm commented Feb 18, 2025

rebase needed

@masz-nordic masz-nordic force-pushed the rx_dummy_cycles branch 4 times, most recently from 9d7f6e8 to 00a0147 Compare February 19, 2025 11:26
@github-actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20309/nrf/dev_model_and_contributions/code_base.html
https://ncsdoc.z6.web.core.windows.net/PR-20309/nrf/installation/install_ncs.html
https://ncsdoc.z6.web.core.windows.net/PR-20309/nrf/releases_and_maturity/release_notes.html
https://ncsdoc.z6.web.core.windows.net/PR-20309/nrf/releases_and_maturity/releases/release-notes-changelog.html

magp-nordic
magp-nordic requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@magp-nordic magp-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking if number of rx dummy cycles is divided by 8 was removed in the recent push.

@mif1-nordic mif1-nordic force-pushed the rx_dummy_cycles branch 3 times, most recently from 14ba45c to 0524c07 Compare February 25, 2025 15:00
@mif1-nordic mif1-nordic mentioned this pull request Feb 25, 2025
Merged
@mif1-nordic
Copy link
Contributor Author

mif1-nordic commented Feb 25, 2025

Checking if number of rx dummy cycles is divided by 8 was removed in the recent push.

Moved the check to VPR because it is better to do it there

@mif1-nordic mif1-nordic requested review from a team as code owners February 27, 2025 10:02
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 27, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

You can find the documentation preview for this PR here.

@mif1-nordic
applications: sdp: mspi: Dummy clocks in rx mode
9104681 
Iplemented Dummy clocks support for rx mode.

Signed-off-by: Michal Frankiewicz <[email protected]>
@github-actions github-actions bot removed the manifest label Mar 4, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mif1-nordic
Copy link
Contributor Author

mif1-nordic commented Mar 11, 2025

Feature realized in different pull request #20731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masz-nordic masz-nordic masz-nordic approved these changes

@magp-nordic magp-nordic magp-nordic approved these changes

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mif1-nordic @NordicBuilder @nordicjm @masz-nordic @magp-nordic